Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#26180] PDF export for time sheets #17269

Closed
wants to merge 26 commits into from
Closed

[#26180] PDF export for time sheets #17269

wants to merge 26 commits into from

Conversation

as-op
Copy link
Contributor

@as-op as-op commented Nov 25, 2024 •
edited
Loading

Ticket

https://community.openproject.org/projects/stream-time-and-costs/work_packages/59824

What are you trying to accomplish?

Export logged time as PDF time sheets

Screenshots

What approach did you choose and why?

Merge checklist

  • Export skeleton PDF via the background worker and a button in the cost report view
  • Don't navigate to .../job_statuses/xyz, use the "inline" progress dialog
  • Apply styling
  • Ellipse text in wp subject cell (missing prawn table support)
  • Table splitting on page breaks with merged rows (missing prawn-table support for splitting)
  • Use cost report query filter & data
  • Use new start_time and time_zone for time on day column
  • Verify used values for header/footer vs wireframes
  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@as-op as-op marked this pull request as draft November 25, 2024 11:32
@as-op as-op changed the title [#26180] PDF export for time sheets; part I: PDF skeleton [#26180] PDF export for time sheets Nov 25, 2024
as-op and others added 20 commits November 25, 2024 14:21
@as-op
obey rubocop
4fd2a2d
@as-op
Merge branch 'dev' into epic/26180-pdf-export-for-time-sheets
3fac7cb
@as-op
follow mockup styling; use current query in pdf export
e6793e8
@as-op
Merge remote-tracking branch 'origin/epic/26180-pdf-export-for-time-s…
f761f69 
…heets' into epic/26180-pdf-export-for-time-sheets
@as-op
obey rubocop
677956e
@as-op
send unsaved cost query settings to export worker
11d5dc8
@as-op
fix missing border if comment is last line
9395e87
@as-op
fix missing border on table split after page break
a6fc8ee
@as-op
fix missing border if comment is last line
2708e0f
@as-op
get rid of cached unsaved filters when a query is changed
7b7233f
@as-op
move text into I18n
a0aebb1
@as-op
don't rely on prawn table for rowspan cells and page breaks; implemen…
e3ea7b9 
…t measuring, splitting and spanning
@as-op
Merge branch 'dev' into epic/26180-pdf-export-for-time-sheets
a67ee2f
@as-op
Merge branch 'dev' into epic/26180-pdf-export-for-time-sheets
9e6a985
@as-op
obey rubocop
744d4af
@as-op
obey rubocop
02dd29f
@as-op
Merge branch 'dev' into epic/26180-pdf-export-for-time-sheets
eff69ff
@as-op
text ellipsis for work package subject cell
6db6058
@as-op
Merge remote-tracking branch 'origin/epic/26180-pdf-export-for-time-s…
9059733 
…heets' into epic/26180-pdf-export-for-time-sheets
@as-op
reduce table font size, remove ellipsing, entry comment in italic fon…
c9e35f9 
…t style, cleanup constants
@as-op as-op closed this Dec 2, 2024
@as-op as-op deleted the epic/26180-pdf-export-for-time-sheets branch December 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@as-op