Fix for bulk editting work packages with hierarchy items #17287
Conversation
brunopagno
force-pushed
the
fix/59734-bulk-edit-hierarchy-items
branch
2 times, most recently
from
2655933 to
f004989
Compare
brunopagno
changed the title
brunopagno
force-pushed
the
fix/59734-bulk-edit-hierarchy-items
branch
from
f004989 to
38ef4a7
Compare
app/helpers/custom_fields_helper.rb
Outdated
| when "hierarchy" | ||
| options = [[I18n.t(:label_no_change_option), ""]] | ||
| service = CustomFields::Hierarchy::HierarchicalItemService.new | ||
| options += service.get_descendants(item: custom_field.hierarchy_root, include_self: false).value!.map do |item| |
There was a problem hiding this comment.
🟡 This goes into a direction, we had already on some other places:
is .value! enough for the failure handling? it means: "Throw on failure". So, while the method currently cannot return a failure, this might change in future, the interface is a Result.
Should we have small .either handling here? Maybe raising (as it is now) or returning empty options together with an error log entry?
There was a problem hiding this comment.
I meant to do that when I refactored, but forgot. Adjusted it now.
There was a problem hiding this comment.
yep, makes sense now. Also this code will eventually get replaced by the specific hierarchy selector (hopefully)
brunopagno
force-pushed
the
fix/59734-bulk-edit-hierarchy-items
branch
from
38ef4a7 to
f9c9780
Compare
brunopagno
force-pushed
the
fix/59734-bulk-edit-hierarchy-items
branch
from
6e19cc4 to
1963d24
Compare
|
I ran the failed test on CI locally and it worked. I'll assume this is fine |
Ticket
The link to the ticket number 59734
What are you trying to accomplish?
Fix bulk edit for work packages that have custom fields with format hierarchy