[22360] Edit lag to follow-precedes-relations

[HDinger]

Ticket

https://community.openproject.org/projects/stream-planning-and-reporting/work_packages/22360/activity

What are you trying to accomplish?

Show and edit the Lag for follows/precedes relationships.

ToDo

Dialog

• Add a text field "Lag" to the Dialogs for follows and precedes relationships
• The text field should show a unit when not focused. On focus, the unit is hidden
• Update the Lag when saving the Dialog

Relations tab

• If a Lag exists, it is shown:
  • before the date for successors
  • after the date for predecessors

Screenshots

Merge checklist

• Added/updated tests

[cbliard]

Code wise, that looks good for me 👍

Regarding the feature, it should not allow negative lag values. This will be possible later but that's in another feature.

And when lag is 0 or unset, it behaves the same regarding scheduling, so I believe it should behave the same in the relations tab: either it displays "lag: 0 days" in both cases, or it should hide the lag information in both case. Currently it display it if lag is 0 and hides it if lag is nil. Between the 2 options, I would prefer hiding it.

[cbliard]

Perfect 👌

[cbliard]

On last CI attempts, the failed tests were different, meaning they pass but are flickering.

• First attempt:
  • spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb:80 failed
• Second attempt:
  • ./spec/features/work_packages/update_ancestors_spec.rb:173 failed
  • modules/boards/spec/features/board_navigation_spec.rb:181 failed

I also tested them locally and they all pass, so it's ok to merge.