Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove user no longer has errornous behaviour #17302

Merged

Conversation

Kharonus
Copy link
Member

What are you trying to accomplish?

  • removing edge cases from code base

What approach did you choose and why?

  • updating NC 28 to NC 29 allows removal of user from its last group
  • removed special handling from tests

@Kharonus Kharonus requested a review from a team November 28, 2024 14:40
@Kharonus Kharonus self-assigned this Nov 28, 2024
- updating NC 28 to NC 29 allows removal of user from its last group
@Kharonus Kharonus force-pushed the chore/update-vcr-record-for-removing-user-from-nextcloud-group branch from 482902e to 33a230b Compare November 28, 2024 15:33
Copy link
Contributor

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if a customer wants to keep using nextcloud 28? Would they become blocked of upgrading openproject if that's the case?

@mereghost
Copy link
Contributor

What happens if a customer wants to keep using nextcloud 28? Would they become blocked of upgrading openproject if that's the case?

IIRC our integrity checks would report it as "non-compatible".

@Kharonus
Copy link
Member Author

Kharonus commented Nov 29, 2024

uhm, maybe we should bump the min NC version then? :D good idea, will ask @dominic-braeunlein

so, dominic:

  • shall we bump the supported min NC version to 29.0.9? In 15.1? This was the version I used for testing the group user removal.
  • we only have checks for versions of our integration app and group folder app
    • we could add a check for NC version, too
    • we could add the supported version of NC to our integration app (e.g. version 2.7.2 is supporting only 29 and up)

@Kharonus
Copy link
Member Author

Kharonus commented Nov 29, 2024

All in all, I'd take the version discussion out of this PR, which basically just amends the tests. no prod code changes. WDYT?

@Kharonus Kharonus merged commit bc48a8a into dev Dec 2, 2024
11 checks passed
@Kharonus Kharonus deleted the chore/update-vcr-record-for-removing-user-from-nextcloud-group branch December 2, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants