enable ordering work packages by hierarchy items #17304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunopagno
force-pushed
the
impl/59766-ordering-for-wp-hierarchy-item
branch
from
9cdcae9 to
a03aec8
Compare
Kharonus
approved these changes
Nov 29, 2024
|
|
||
| def join_for_order_by_hierarchy_sql | ||
| table_name = CustomField::Hierarchy::Item.quoted_table_name | ||
| join_for_order_sql(value: "item.label", join: "INNER JOIN #{table_name} item ON item.id = cv.value::bigint") |
There was a problem hiding this comment.
There was a problem hiding this comment.
I just implemented the simples possible way forward.
To be fair this could also be extended to handle multi values... I think it's fair to bring to discussion.
brunopagno
force-pushed
the
impl/59766-ordering-for-wp-hierarchy-item
branch
from
a03aec8 to
441f320
Compare
|
Flaky test looks green locally on the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59766
What are you trying to accomplish?
Enable ordering by custom field hierarchies on work packages
Screenshots
Screencast.From.2024-11-29.08-25-21.mp4
Merge checklist