-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF export for time sheets #17316
PDF export for time sheets #17316
Conversation
…to the job status url
…heets' into epic/26180-pdf-export-for-time-sheets
…t measuring, splitting and spanning
…heets' into epic/26180-pdf-export-for-time-sheets
…t style, cleanup constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
I left some comments inline. We seem to work under the assumption that the Timesheet is the only PDF export we will ever generate for reports. I think it will be easy enough to add another parameter that tells us what type of PDF we want to generate, so that there is no need to do anything right now.
All in all, awesome work. Especially the edge case handling for weird PDF behavior.
modules/reporting/app/workers/cost_query/pdf/timesheet_generator.rb
Outdated
Show resolved
Hide resolved
modules/reporting/app/workers/cost_query/pdf/timesheet_generator.rb
Outdated
Show resolved
Hide resolved
…or.rb Co-authored-by: Klaus Zanders <[email protected]>
…ler.ts Co-authored-by: Klaus Zanders <[email protected]>
…-as-timesheet-pdf' into feature/59824-export-cost-report-as-timesheet-pdf
Co-authored-by: Klaus Zanders <[email protected]>
…-as-timesheet-pdf' into feature/59824-export-cost-report-as-timesheet-pdf
Ticket
https://community.openproject.org/projects/stream-time-and-costs/work_packages/59824
What are you trying to accomplish?
Export logged time as PDF time sheets
Screenshots
What approach did you choose and why?
Merge checklist