implementation/59434 visualize reminders in notification center #17323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
akabiru
force-pushed
the
implementation/59434-visualize-reminders-in-notification-center
branch
from
16e1a4a to
0c28552
Compare
akabiru
force-pushed
the
implementation/59434-visualize-reminders-in-notification-center
branch
from
9a84a6f to
0bd9b08
Compare
Base automatically changed from
implementation/59433-define-database-model-for-reminders
to
dev
December 4, 2024 14:50
akabiru
force-pushed
the
implementation/59434-visualize-reminders-in-notification-center
branch
from
0bd9b08 to
cb7af7e
Compare
akabiru
changed the base branch from
dev
to
implementation/59721-add-setedit-reminder-buttondialog-to-workpackage-page
akabiru
force-pushed
the
implementation/59434-visualize-reminders-in-notification-center
branch
from
1564bd5 to
b3053fa
Compare
This reverts commit 220ca16. Separates commit for easier code review
Reminders have first priority against all other kinds of notifications in the index view
The full stop acts a separator between the relative time and note
akabiru
force-pushed
the
implementation/59434-visualize-reminders-in-notification-center
branch
from
b3053fa to
2ad579f
Compare
Match the icons for the "Set reminders" modal action and the reminders menu filter
3 tasks
…to-workpackage-page' into implementation/59434-visualize-reminders-in-notification-center
oliverguenther
approved these changes
Dec 11, 2024
jjabari-op
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Great work @akabiru 🎉
I didn't find any code related issues. Only UI wise I saw the mobile issue already described in our last meeting. Still approving it!
| [notification]="reminderAlert" | ||
| [hasActorByLine]="false" | ||
| /> | ||
| <span |
There was a problem hiding this comment.
I still see the issue raised by wieland in our last meeting as well - a longer note text gets hidden on mobile
There was a problem hiding this comment.
Thanks! I had planned on resolving separately in https://community.openproject.org/wp/59989 but it should also be small enough to fit here 👍🏾
Base automatically changed from
implementation/59721-add-setedit-reminder-buttondialog-to-workpackage-page
to
dev
December 12, 2024 09:57
akabiru
deleted the
implementation/59434-visualize-reminders-in-notification-center
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/communicator-stream/work_packages/59434
Follows #17341, #17229
Screenshots
What approach did you choose and why?
Extract "relative time" into a standalone component- reused in actors-inline and reminders components.
Reminders are given first priority in the notification entry footer- so that notes can be displayed.
Extract reminder notifications from aggregation groups so that they are rendered as standalone and can also be managed as standalone.
Merge checklist