Do not reload the relations tab after a hierarchy change. #17332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Stabilize the
relations/hierarchy_spec.rbWhat approach did you choose and why?
The test always failed after a parent and a child have been removed from a WorkPackage. After the parent is removed, the relations tab was updated. I assume, that the test was so fast, that it deleted the Child before the tab content was updated and thus someting went wrong. However, since Parents are not part of the relations tab (or the counter), it is not necessary to reload the tab after parent change.
This appears due to the changes made in the scope of https://community.openproject.org/projects/stream-planning-and-reporting/work_packages/58345/activity