Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/58161 global stage administration #17358

Draft
wants to merge 30 commits into
base: dev
Choose a base branch
from

Conversation

toy
Copy link
Contributor

@toy toy commented Dec 4, 2024

Ticket

OP#58161

What are you trying to accomplish?

Allow global stage administration

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy toy force-pushed the feature/58161-global-stage-administration branch 6 times, most recently from 799692d to 516961c Compare December 11, 2024 19:39
@toy toy force-pushed the feature/58161-global-stage-administration branch 3 times, most recently from 01f3ec8 to 9d10847 Compare December 12, 2024 19:06
app/models/application_record.rb Dismissed Show dismissed Hide dismissed
@toy toy changed the base branch from dev to feature/58163-project-specific-stage-administration December 13, 2024 14:35
@toy toy force-pushed the feature/58161-global-stage-administration branch 2 times, most recently from b5aa03b to ef3ae5d Compare December 13, 2024 14:39
Base automatically changed from feature/58163-project-specific-stage-administration to dev December 16, 2024 08:37
@toy toy force-pushed the feature/58161-global-stage-administration branch from 312461a to 01e2e41 Compare December 16, 2024 14:45
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @toy,

I am aware that the PR is not yet done so sorry if I criticised anything you would have done anyway.

But the general direction is already looking good so I thought I could start on the details :).

app/helpers/highlighting_helper.rb Show resolved Hide resolved
app/models/application_record.rb Show resolved Hide resolved
config/locales/en.yml Show resolved Hide resolved
@@ -3729,6 +3736,27 @@ en:
new:
heading: "New attribute"
description: "Changes to this project attribute will be reflected in all projects where it is enabled. Required attributes cannot be disabled on a per-project basis."
project_life_cycle_step_definitions:
heading: "Project lifecycle"
heading_description: "Project lifecycle define the project stages and gates that can be used for your project planning and will appear in the overview page of each project. These attributes can be enabled or disabled but not re-ordered at a project level."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a grammar error in here. It would have to be "Project lifecycle defines" (with the s).

In any case, I suggest to rephrase the text a bit:

"The project lifecycle consists of stages and gates that structure your projects. They will appear in the overview page of a project and be available in the projects list. Individual stages and gates can be selected to customize a project but reordering is not possible on a project level."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toy toy force-pushed the feature/58161-global-stage-administration branch from 923207d to ea7eeac Compare December 17, 2024 14:52
@toy toy force-pushed the feature/58161-global-stage-administration branch from b63fae5 to d66c408 Compare December 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants