-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/58161 global stage administration #17358
base: dev
Are you sure you want to change the base?
Conversation
799692d
to
516961c
Compare
01f3ec8
to
9d10847
Compare
b5aa03b
to
ef3ae5d
Compare
312461a
to
01e2e41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @toy,
I am aware that the PR is not yet done so sorry if I criticised anything you would have done anyway.
But the general direction is already looking good so I thought I could start on the details :).
app/components/settings/project_life_cycle_step_definitions/form_header_component.html.erb
Outdated
Show resolved
Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb
Outdated
Show resolved
Hide resolved
app/components/settings/project_life_cycle_step_definitions/row_component.html.erb
Show resolved
Hide resolved
app/components/settings/project_life_cycle_step_definitions/row_component.html.erb
Show resolved
Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb
Outdated
Show resolved
Hide resolved
app/views/admin/settings/project_life_cycle_step_definitions/form.html.erb
Outdated
Show resolved
Hide resolved
config/locales/en.yml
Outdated
@@ -3729,6 +3736,27 @@ en: | |||
new: | |||
heading: "New attribute" | |||
description: "Changes to this project attribute will be reflected in all projects where it is enabled. Required attributes cannot be disabled on a per-project basis." | |||
project_life_cycle_step_definitions: | |||
heading: "Project lifecycle" | |||
heading_description: "Project lifecycle define the project stages and gates that can be used for your project planning and will appear in the overview page of each project. These attributes can be enabled or disabled but not re-ordered at a project level." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a grammar error in here. It would have to be "Project lifecycle defines" (with the s).
In any case, I suggest to rephrase the text a bit:
"The project lifecycle consists of stages and gates that structure your projects. They will appear in the overview page of a project and be available in the projects list. Individual stages and gates can be selected to customize a project but reordering is not possible on a project level."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
923207d
to
ea7eeac
Compare
…nitialized itself
…tep definitions interfaces
…n't become visible with next flash message
…n name is too long
b63fae5
to
d66c408
Compare
Ticket
OP#58161
What are you trying to accomplish?
Allow global stage administration
Merge checklist