Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show day of week when not weekly #17359

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Don't show day of week when not weekly #17359

merged 1 commit into from
Dec 5, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Dec 4, 2024 •
edited
Loading

Template details shows a day of the week when frequency is working days as well

@oliverguenther oliverguenther mentioned this pull request Dec 4, 2024
Merged
49 tasks
@oliverguenther oliverguenther requested a review from mrmir December 4, 2024 18:59
@oliverguenther oliverguenther force-pushed the fix/meeting-template-working-days branch from fde6842 to 22a4eb2 Compare December 5, 2024 08:20
mrmir
mrmir approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mrmir mrmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected in terms of functionality 👍

However, there is a change in the sidepanel size when switching between Weekly and the others. Not sure if that needs to be handled here

@oliverguenther
Copy link
Member Author

This works as expected in terms of functionality 👍

However, there is a change in the sidepanel size when switching between Weekly and the others. Not sure if that needs to be handled here

I guess that's expected currently, since we show fewer items?

@oliverguenther oliverguenther merged commit 11fdf34 into dev Dec 5, 2024
11 checks passed
@oliverguenther oliverguenther deleted the fix/meeting-template-working-days branch December 5, 2024 09:13
@mrmir
Copy link
Contributor

mrmir commented Dec 5, 2024

This works as expected in terms of functionality 👍
However, there is a change in the sidepanel size when switching between Weekly and the others. Not sure if that needs to be handled here

I guess that's expected currently, since we show fewer items?

In terms of width, I should have specified...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmir mrmir mrmir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @mrmir