Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meeting series template to allow finalizing the template #17365

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Update meeting series template to allow finalizing the template #17365

merged 2 commits into from
Dec 6, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther force-pushed the feature/meeting-template-blankslate branch from 325ce2b to 4668d7e Compare December 5, 2024 09:22
@oliverguenther oliverguenther requested a review from mrmir December 5, 2024 09:54
@oliverguenther
Copy link
Member Author

Failing spec is unrelated (primerized relations)

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
mrmir
mrmir approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@mrmir mrmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

modules/meeting/spec/requests/recurring_meetings/recurring_meetings_template_completed_spec.rb
start_time: recurring_meeting.start_time
end

it "takes over that occurrence" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mrmir mrmir removed the needs review label Dec 6, 2024
@oliverguenther oliverguenther merged commit 0cffa57 into dev Dec 6, 2024
18 of 19 checks passed
@oliverguenther oliverguenther deleted the feature/meeting-template-blankslate branch December 6, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmir mrmir mrmir approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @mrmir