Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/59458 activity tab does not scroll to the bottom or correct comment on mobile #17374

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Bug/59458 activity tab does not scroll to the bottom or correct comment on mobile #17374

merged 3 commits into from
Dec 10, 2024

Conversation

jjabari-op
Copy link
Collaborator

@jjabari-op jjabari-op self-assigned this Dec 5, 2024
@jjabari-op jjabari-op requested a review from akabiru December 5, 2024 14:17
akabiru
akabiru approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA looks good 👍🏾 In this instance, a brief write-up of your approach would have been helpful- we have this in the "What approach did you take and why" in the pull request template

@jjabari-op jjabari-op merged commit bb9b1c9 into dev Dec 10, 2024
11 checks passed
@jjabari-op jjabari-op deleted the bug/59458-activity-tab-does-not-scroll-to-the-bottom-or-correct-comment-on-mobile branch December 10, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akabiru akabiru akabiru approved these changes

Assignees

@jjabari-op jjabari-op

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjabari-op @akabiru