Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore fetch changesets functionality #17382

Merged
merged 1 commit into from
Dec 6, 2024

Restore fetch changesets functionality

ff7e05e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Restore fetch changesets functionality #17382

Restore fetch changesets functionality
ff7e05e
Select commit
Loading
Failed to load commit list.
GitHub Actions / rubocop failed Dec 6, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (3)

app/controllers/sys_controller.rb|46 col 3| Assignment Branch Condition size for fetch_changesets is too high. [<3, 18, 5> 18.92/17]
app/controllers/sys_controller.rb|55 col 7| Use safe navigation (&.) instead of checking if an object exists before calling the method.
spec/controllers/sys_controller_spec.rb|507 col 7| Avoid stubbing using allow_any_instance_of.

Filtered Findings (0)

Annotations

Check notice on line 62 in app/controllers/sys_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/controllers/sys_controller.rb#L46-L62 <Metrics/AbcSize>

Assignment Branch Condition size for fetch_changesets is too high. [<3, 18, 5> 18.92/17]
Raw output
app/controllers/sys_controller.rb:46:3: C: Metrics/AbcSize: Assignment Branch Condition size for fetch_changesets is too high. [<3, 18, 5> 18.92/17]

Check notice on line 57 in app/controllers/sys_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/controllers/sys_controller.rb#L55-L57 <Style/SafeNavigation>

Use safe navigation (`&.`) instead of checking if an object exists before calling the method.
Raw output
app/controllers/sys_controller.rb:55:7: C: Style/SafeNavigation: Use safe navigation (`&.`) instead of checking if an object exists before calling the method.

Check notice on line 507 in spec/controllers/sys_controller_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] spec/controllers/sys_controller_spec.rb#L507 <RSpec/AnyInstance>

Avoid stubbing using `allow_any_instance_of`.
Raw output
spec/controllers/sys_controller_spec.rb:507:7: C: RSpec/AnyInstance: Avoid stubbing using `allow_any_instance_of`.