Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use service to clean sessions #17383

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Use service to clean sessions #17383

merged 2 commits into from
Dec 8, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Dec 6, 2024 •
edited
Loading

@oliverguenther oliverguenther force-pushed the fix/rake-sessions-job branch 2 times, most recently from 71e2dcc to 0b8e980 Compare December 6, 2024 08:25
oliverguenther
oliverguenther commented Dec 6, 2024
View reviewed changes
app/workers/cron/clear_old_sessions_job.rb
@@ -31,7 +31,7 @@ class ClearOldSessionsJob < ApplicationJob
include ::RakeJob

def perform
super("db:sessions:expire", 7)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was set to 7 by default, which seems a bit low for a cleanup

klaustopher
klaustopher approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@klaustopher klaustopher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I'd suggest to simplify the query to not use a raw SQL. That would also fix the brakeman report about a possible injection

@oliverguenther oliverguenther merged commit ec169ae into dev Dec 8, 2024
9 of 11 checks passed
@oliverguenther oliverguenther deleted the fix/rake-sessions-job branch December 8, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaustopher klaustopher klaustopher approved these changes

Assignees
No one assigned
Labels
maintenance needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @klaustopher