Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show frequency and interval in horizontal group #17411

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

oliverguenther
Copy link
Member

Instead of showing frequency and interval below each other, show them in a horizontal group. With Marc we decided we wanted to hide the field visibly, but keep it blocked (so that frequency input doesn't increase in size)

@mrmir
Copy link
Contributor

mrmir commented Dec 9, 2024

While this looks good from a code perspective, I can't get past how odd it looks in the form when every working day is selected with the space to the side but also the extra space below.

Maybe this needs another discussion with the live version visible now via pull preview or whatever? If we need to keep it this way, I think pushing this group to the end of the form might help the layout look less janky, unless all of this has been discussed already.

@mrmir mrmir removed the needs review label Dec 9, 2024
@oliverguenther
Copy link
Member Author

Maybe this needs another discussion with the live version visible now via pull preview or whatever? If we need to keep it this way, I think pushing this group to the end of the form might help the layout look less janky, unless all of this has been discussed already.

This has been discussed exactly like this, so that the group stays on the left hand side. I showed it earlier with the frequency becoming 100% width and that felt weird too.

I'll merge it so we can gather feedback

@oliverguenther oliverguenther merged commit f74bea7 into dev Dec 9, 2024
11 checks passed
@oliverguenther oliverguenther deleted the fix/meeting-horizontal-frequency branch December 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants