Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation/59815 Add email setting to send an email reminder immediately #17461

Merged
merged 5 commits into from
Dec 19, 2024
Merged

implementation/59815 Add email setting to send an email reminder immediately #17461

merged 5 commits into from
Dec 19, 2024

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Dec 13, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/59815

What are you trying to accomplish?

  • Add email setting to send an email reminder immediately
    • Dispatch personal reminder emails based on setting
    • Update email template design (Starts out as similar to notification, will be updated separately once there is a design in https://community.openproject.org/wp/60201)

Screenshots

Screenshot 2024-12-14 at 1 27 19 AM Screenshot 2024-12-17 at 1 15 45 PM

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@akabiru akabiru force-pushed the implementation/59815-add-email-setting-to-send-an-email-reminder-immediately branch 3 times, most recently from 05c1b3e to f738001 Compare December 13, 2024 21:34
@akabiru akabiru force-pushed the implementation/59815-add-email-setting-to-send-an-email-reminder-immediately branch from f738001 to d049728 Compare December 13, 2024 21:44
@akabiru akabiru added this to the 15.2.x milestone Dec 13, 2024
@akabiru akabiru self-assigned this Dec 13, 2024
@akabiru akabiru force-pushed the implementation/59815-add-email-setting-to-send-an-email-reminder-immediately branch from 7128cb6 to 1cf2bb4 Compare December 17, 2024 12:11
@akabiru akabiru marked this pull request as ready for review December 17, 2024 12:19
@akabiru akabiru changed the title [#59815] Add email setting to send an email reminder immediately implementation/59815 Add email setting to send an email reminder immediately Dec 17, 2024
@akabiru akabiru requested a review from brunopagno December 17, 2024 13:08
brunopagno
brunopagno approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@brunopagno brunopagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good 🎉

I was able to test locally and it works as expected 😎

Left a few minor comments if you want to take a look, but consider the PR ✔️ approved

@akabiru akabiru merged commit d276165 into dev Dec 19, 2024
13 checks passed
@akabiru akabiru deleted the implementation/59815-add-email-setting-to-send-an-email-reminder-immediately branch December 19, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunopagno brunopagno brunopagno approved these changes

Assignees

@akabiru akabiru

Labels
needs review
Milestone
15.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@akabiru @brunopagno