Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up huge project index spec into separate files #17471

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ulferts
Copy link
Contributor

@ulferts ulferts commented Dec 16, 2024

What are you trying to accomplish?

The projects index spec file has become unwieldy. It was thus split into 4 individual files:

  • Columns
  • Filters
  • Order
  • Table - This one still contains a variety of specs but mostly they are checking for the behaviour of the table. Some of those also are overarching e.g. when pagination is checked, the spec also assures that columns and filters are kept.

The commit only changes the structure of the files. It does not add/remove/alter the specs themselves. The only exception to this is that it removes a spec that was never implemented and only marked as pending.

@ulferts ulferts force-pushed the chore/split_up_projects_index_spec branch from 3f95120 to 019413a Compare December 16, 2024 12:46
@ulferts ulferts marked this pull request as ready for review December 16, 2024 15:13
@EinLama EinLama self-requested a review December 16, 2024 15:18
@ulferts ulferts merged commit f287819 into dev Dec 17, 2024
13 checks passed
@ulferts ulferts deleted the chore/split_up_projects_index_spec branch December 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants