Replace references for AuthProvider #17477
Merged
+68
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
fix/auth-provider-replace-references
branch
from
8a120c5 to
204ed96
Compare
oliverguenther
changed the title
NobodysNightmare
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
LGTM. I think this is the proper way to address the bug for 15.1. I performed the refactoring that we discussed today in #17480, but that one targets dev, since the amount of changes there is more risky and thus probably not suitable for a patch release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/60172