Mock browser login for integration specs. #17488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dombesz
force-pushed
the
code-maintenance/mock-integration-login
branch
from
d74da1d to
e1de8c7
Compare
dombesz
force-pushed
the
code-maintenance/mock-integration-login
branch
from
e1de8c7 to
6587a30
Compare
|
After running the specs a few times, there is no significant performance increase. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
What are you trying to accomplish?
Speed up integration specs by mocking login.
Screenshots
What approach did you choose and why?
Looks like mocking the login might be a viable approach for the majority of integration specs. This PR is testing the modification.
Merge checklist