Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#60291] Apply view permissions on the Project List page #17496

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Dec 18, 2024

Ticket

https://community.openproject.org/work_packages/60291

What are you trying to accomplish?

Apply stages and gates view permissions on the project list page.

  • Do not display the Stage and Gate definitions, if the user does not have the :view_project_stages_and_gates permission in any projects.
  • Do not display Stages and Gates value entries for projects without the :view_project_stages_and_gates.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@dombesz dombesz marked this pull request as ready for review December 18, 2024 15:35
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dombesz I fear it is a bit more complicated. It might be that the user has the permission to see the dates in one project but doesn't have it in the next. So if the user lists projects, the dates set for the former should be visible but at the same time, they should be invisible on the later.

@dombesz
Copy link
Contributor Author

dombesz commented Dec 18, 2024

Thanks @ulferts , I'll add the permissions verification on the row level.

@dombesz
Copy link
Contributor Author

dombesz commented Dec 19, 2024

Hi @ulferts I addressed your CR comments.

@oliverguenther oliverguenther merged commit 7512be8 into dev Dec 20, 2024
13 checks passed
@oliverguenther oliverguenther deleted the implementation/60291-apply-view-permissions-on-the-project-list-page branch December 20, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants