Allow authorization before_action using given permission #17503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaustopher
approved these changes
Dec 19, 2024
oliverguenther
force-pushed
the
refactor/authorize-on-permission
branch
from
9ab5318 to
5e5fa5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With more and more smaller actions that happen on controllers for e.g., turbo-specific actions, adding all of them in the engine is becoming cumbersome and harder to understand.
Instead, this PR suggests to allow authorization to happen on permissions, not only actions. This was possibly already but required us to manually whitelist the action from the default authorization checks. By providing two helper methods, we can re-use most of the same logic but extend them for permissions.