Code maintenance/53379 separate filtering from projections in queries #27385
reviewdog [rubocop] report
reported by reviewdog 🐶
Findings (1)
app/helpers/sort_helper.rb|327 col 64| Space missing after comma.
Filtered Findings (72)
app/components/projects/index_page_header_component.rb|31 col 7| Missing Lookbook preview for /home/runner/work/openproject/openproject/app/components/projects/index_page_header_component.rb. Expected preview to exist at /home/runner/work/openproject/openproject/lookbook/previews/projects/index_page_header_component_preview.rb.
app/components/projects/row_component.rb|31 col 9| Missing Lookbook preview for /home/runner/work/openproject/openproject/app/components/projects/row_component.rb. Expected preview to exist at /home/runner/work/openproject/openproject/lookbook/previews/projects/row_component_preview.rb.
app/components/projects/row_component.rb|76 col 5| Assignment Branch Condition size for custom_field_column is too high. [<2, 16, 6> 17.2/17]
app/components/table_component.rb|33 col 7| Missing Lookbook preview for /home/runner/work/openproject/openproject/app/components/table_component.rb. Expected preview to exist at /home/runner/work/openproject/openproject/lookbook/previews/table_component_preview.rb.
app/components/table_component.rb|34 col 28| Use anonymous keyword arguments forwarding (**
).
app/components/table_component.rb|35 col 17| Use anonymous keyword arguments forwarding (**
).
app/helpers/projects_helper.rb|54 col 8| Use filter_map
instead.
app/helpers/sort_helper.rb|86 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|96 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|100 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|105 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|123 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|124 col 24| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|139 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|140 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|140 col 34| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|151 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|151 col 7| Use safe navigation (&.
) instead of checking if an object exists before calling the method.
app/helpers/sort_helper.rb|151 col 26| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|155 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|155 col 7| Use safe navigation (&.
) instead of checking if an object exists before calling the method.
app/helpers/sort_helper.rb|155 col 26| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|159 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|166 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|166 col 19| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|171 col 10| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|172 col 9| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|172 col 21| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|172 col 48| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|175 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|179 col 37| Prefer keyword arguments for arguments with a boolean default value; use asc: true
instead of asc = true
.
app/helpers/sort_helper.rb|201 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|205 col 7| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|210 col 5| Prefer string interpolation to string concatenation.
app/helpers/sort_helper.rb|230 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|231 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|239 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|240 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|241 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|242 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|242 col 31| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|242 col 57| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|243 col 26| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|256 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|260 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|266 col 5| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|266 col 31| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|281 col 18| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|338 col 23| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|339 col 10| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|361 col 23| Do not use instance variables in helpers.
app/helpers/sort_helper.rb|362 col 15| Do not use instance variables in helpers.
app/models/news.rb|32 col 3| Specify an :inverse_of
option.
app/models/wiki_page.rb|32 col 35| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/models/wiki_page.rb|35 col 44| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/models/wiki_page.rb|48 col 51| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/models/wiki_page.rb|48 col 68| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/models/wiki_page.rb|57 col 49| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/models/wiki_page.rb|65 col 24| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/models/wiki_page.rb|122 col 3| Assignment Branch Condition size for update_redirects is too high. [<7, 34, 9> 35.86/17]
app/models/wiki_page.rb|134 col 118| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
app/models/wiki_page.rb|180 col 26| Call super
without arguments and parentheses when the signature is identical.
app/models/wiki_page.rb|187 col 21| Method parameter must be at least 3 characters long.
modules/meeting/app/models/meeting.rb|52 col 30| Use where(start_time: Date.tomorrow.beginning_of_day..)
instead of manually constructing SQL.
modules/meeting/app/models/meeting.rb|53 col 27| Use where(start_time: Time.zone.today.beginning_of_day..)
instead of manually constructing SQL.
modules/meeting/app/models/meeting.rb|177 col 3| Assignment Branch Condition size for group_by_time is too high. [<14, 14, 6> 20.69/17]
modules/meeting/app/models/meeting.rb|185 col 52| Shadowing outer local variable - objs
.
modules/meeting/app/models/meeting.rb|186 col 52| Shadowing outer local variable - objs
.
modules/meeting/app/models/meeting.rb|195 col 3| Assignment Branch Condition size for close_agenda_and_copy_to_minutes! is too high. [<10, 21, 8> 24.6/17]
spec/models/queries/news/news_query_spec.rb|77 col 26| Use expect(...).not_to be_valid
.
spec/requests/api/v3/principals/principals_resource_spec.rb|91 col 7| Prefer expect(response).to have_http_status(200)
over expect(response.status) .to eq(200)
.
spec/requests/api/v3/principals/principals_resource_spec.rb|259 col 131| Line is too long. [419/130]
Annotations
Check notice on line 327 in app/helpers/sort_helper.rb
github-actions / rubocop
[rubocop] app/helpers/sort_helper.rb#L327 <Layout/SpaceAfterComma>
Space missing after comma.
Raw output
app/helpers/sort_helper.rb:327:64: C: Layout/SpaceAfterComma: Space missing after comma.