Skip to content

Allow seeding with path config as shown in docs

Sign in for the full log view
GitHub Actions / rubocop failed Oct 15, 2024 in 1s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (11)

modules/openid_connect/app/controllers/openid_connect/providers_controller.rb|50 col 131| Line is too long. [142/130]
modules/openid_connect/app/services/openid_connect/configuration_mapper.rb|59 col 41| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
modules/openid_connect/app/services/openid_connect/configuration_mapper.rb|70 col 7| Add empty line after guard clause.
modules/openid_connect/app/services/openid_connect/providers/update_service.rb|43 col 7| Assignment Branch Condition size for after_validate is too high. [<13, 35, 9> 38.41/17]
modules/openid_connect/app/services/openid_connect/providers/update_service.rb|43 col 7| Perceived complexity for after_validate is too high. [9/8]
modules/openid_connect/app/services/openid_connect/providers/update_service.rb|67 col 49| Avoid manipulating ActiveModel errors as hash directly.
modules/openid_connect/spec/seeders/env_data/openid_connect/provider_seeder_spec.rb|33 col 1| Spec path should end with env_data/open_id_connect/provider_seeder*_spec.rb.
spec/services/users/register_user_service_spec.rb|105 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/services/users/register_user_service_spec.rb|118 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/services/users/register_user_service_spec.rb|133 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/services/users/register_user_service_spec.rb|149 col 38| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Filtered Findings (0)

Annotations

Check notice on line 50 in modules/openid_connect/app/controllers/openid_connect/providers_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/openid_connect/app/controllers/openid_connect/providers_controller.rb#L50 <Layout/LineLength>

Line is too long. [142/130]
Raw output
modules/openid_connect/app/controllers/openid_connect/providers_controller.rb:50:131: C: Layout/LineLength: Line is too long. [142/130]

Check notice on line 59 in modules/openid_connect/app/services/openid_connect/configuration_mapper.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/configuration_mapper.rb#L59 <Style/StringLiterals>

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw output
modules/openid_connect/app/services/openid_connect/configuration_mapper.rb:59:41: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Check notice on line 70 in modules/openid_connect/app/services/openid_connect/configuration_mapper.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/configuration_mapper.rb#L70 <Layout/EmptyLineAfterGuardClause>

Add empty line after guard clause.
Raw output
modules/openid_connect/app/services/openid_connect/configuration_mapper.rb:70:7: C: Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.

Check notice on line 82 in modules/openid_connect/app/services/openid_connect/providers/update_service.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/providers/update_service.rb#L43-L82 <Metrics/AbcSize>

Assignment Branch Condition size for after_validate is too high. [<13, 35, 9> 38.41/17]
Raw output
modules/openid_connect/app/services/openid_connect/providers/update_service.rb:43:7: C: Metrics/AbcSize: Assignment Branch Condition size for after_validate is too high. [<13, 35, 9> 38.41/17]

Check notice on line 82 in modules/openid_connect/app/services/openid_connect/providers/update_service.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/providers/update_service.rb#L43-L82 <Metrics/PerceivedComplexity>

Perceived complexity for after_validate is too high. [9/8]
Raw output
modules/openid_connect/app/services/openid_connect/providers/update_service.rb:43:7: C: Metrics/PerceivedComplexity: Perceived complexity for after_validate is too high. [9/8]

Check warning on line 67 in modules/openid_connect/app/services/openid_connect/providers/update_service.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/openid_connect/app/services/openid_connect/providers/update_service.rb#L67 <Rails/DeprecatedActiveModelErrorsMethods>

Avoid manipulating ActiveModel errors as hash directly.
Raw output
modules/openid_connect/app/services/openid_connect/providers/update_service.rb:67:49: W: Rails/DeprecatedActiveModelErrorsMethods: Avoid manipulating ActiveModel errors as hash directly.

Check notice on line 33 in modules/openid_connect/spec/seeders/env_data/openid_connect/provider_seeder_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/openid_connect/spec/seeders/env_data/openid_connect/provider_seeder_spec.rb#L33 <RSpec/SpecFilePathFormat>

Spec path should end with `env_data/open_id_connect/provider_seeder*_spec.rb`.
Raw output
modules/openid_connect/spec/seeders/env_data/openid_connect/provider_seeder_spec.rb:33:1: C: RSpec/SpecFilePathFormat: Spec path should end with `env_data/open_id_connect/provider_seeder*_spec.rb`.

Check notice on line 105 in spec/services/users/register_user_service_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] spec/services/users/register_user_service_spec.rb#L105 <Style/StringLiterals>

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw output
spec/services/users/register_user_service_spec.rb:105:38: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Check notice on line 118 in spec/services/users/register_user_service_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] spec/services/users/register_user_service_spec.rb#L118 <Style/StringLiterals>

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw output
spec/services/users/register_user_service_spec.rb:118:38: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Check notice on line 133 in spec/services/users/register_user_service_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] spec/services/users/register_user_service_spec.rb#L133 <Style/StringLiterals>

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw output
spec/services/users/register_user_service_spec.rb:133:38: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Check notice on line 149 in spec/services/users/register_user_service_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] spec/services/users/register_user_service_spec.rb#L149 <Style/StringLiterals>

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw output
spec/services/users/register_user_service_spec.rb:149:38: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.