Skip to content

Recurring meetings #17540

Recurring meetings

Recurring meetings #17540

GitHub Actions / rubocop failed Nov 28, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (14)

modules/meeting/app/components/meetings/combined_filter_component.rb|36 col 28| Place optional keyword parameters at the end of the parameters list.
modules/meeting/app/components/meetings/index_sub_header_component.rb|37 col 28| Place optional keyword parameters at the end of the parameters list.
modules/meeting/app/components/recurring_meetings/row_component.rb|37 col 5| Use delegate to define delegations.
modules/meeting/app/components/recurring_meetings/row_component.rb|104 col 41| Space inside } missing.
modules/meeting/app/components/recurring_meetings/show_page_header_component.rb|68 col 27| Prefer string interpolation to string concatenation.
modules/meeting/app/components/recurring_meetings/show_page_sub_header_component.rb|37 col 30| Place optional keyword parameters at the end of the parameters list.
modules/meeting/app/controllers/meetings_controller.rb|72 col 3| Assignment Branch Condition size for show is too high. [<2, 16, 7> 17.58/17]
modules/meeting/app/forms/recurring_meeting/frequency.rb|39 col 36| Use each_key instead of keys.each.
modules/meeting/app/forms/recurring_meeting/interval.rb|35 col 65| Avoid comma after the last parameter of a method call.
modules/meeting/app/forms/recurring_meeting/specific_date.rb|43 col 3| Call super to initialize state of the parent class.
modules/meeting/spec/models/recurring_meeting_spec.rb|1 col 9| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
modules/meeting/spec/models/recurring_meeting_spec.rb|3 col 34| Remove redundant spec type.
modules/meeting/spec/requests/recurring_meetings_spec.rb|1 col 9| Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
modules/meeting/spec/requests/recurring_meetings_spec.rb|3 col 37| Remove redundant spec type.

Filtered Findings (0)

Annotations

Check notice on line 36 in modules/meeting/app/components/meetings/combined_filter_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/components/meetings/combined_filter_component.rb#L36 <Style/KeywordParametersOrder>

Place optional keyword parameters at the end of the parameters list.
Raw output
modules/meeting/app/components/meetings/combined_filter_component.rb:36:28: C: Style/KeywordParametersOrder: Place optional keyword parameters at the end of the parameters list.

Check notice on line 37 in modules/meeting/app/components/meetings/index_sub_header_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/components/meetings/index_sub_header_component.rb#L37 <Style/KeywordParametersOrder>

Place optional keyword parameters at the end of the parameters list.
Raw output
modules/meeting/app/components/meetings/index_sub_header_component.rb:37:28: C: Style/KeywordParametersOrder: Place optional keyword parameters at the end of the parameters list.

Check notice on line 37 in modules/meeting/app/components/recurring_meetings/row_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/components/recurring_meetings/row_component.rb#L37 <Rails/Delegate>

Use `delegate` to define delegations.
Raw output
modules/meeting/app/components/recurring_meetings/row_component.rb:37:5: C: Rails/Delegate: Use `delegate` to define delegations.

Check notice on line 104 in modules/meeting/app/components/recurring_meetings/row_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/components/recurring_meetings/row_component.rb#L104 <Layout/SpaceInsideHashLiteralBraces>

Space inside } missing.
Raw output
modules/meeting/app/components/recurring_meetings/row_component.rb:104:41: C: Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

Check notice on line 68 in modules/meeting/app/components/recurring_meetings/show_page_header_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/components/recurring_meetings/show_page_header_component.rb#L68 <Style/StringConcatenation>

Prefer string interpolation to string concatenation.
Raw output
modules/meeting/app/components/recurring_meetings/show_page_header_component.rb:68:27: C: Style/StringConcatenation: Prefer string interpolation to string concatenation.

Check notice on line 37 in modules/meeting/app/components/recurring_meetings/show_page_sub_header_component.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/components/recurring_meetings/show_page_sub_header_component.rb#L37 <Style/KeywordParametersOrder>

Place optional keyword parameters at the end of the parameters list.
Raw output
modules/meeting/app/components/recurring_meetings/show_page_sub_header_component.rb:37:30: C: Style/KeywordParametersOrder: Place optional keyword parameters at the end of the parameters list.

Check notice on line 87 in modules/meeting/app/controllers/meetings_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/controllers/meetings_controller.rb#L72-L87 <Metrics/AbcSize>

Assignment Branch Condition size for show is too high. [<2, 16, 7> 17.58/17]
Raw output
modules/meeting/app/controllers/meetings_controller.rb:72:3: C: Metrics/AbcSize: Assignment Branch Condition size for show is too high. [<2, 16, 7> 17.58/17]

Check notice on line 39 in modules/meeting/app/forms/recurring_meeting/frequency.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/forms/recurring_meeting/frequency.rb#L39 <Style/HashEachMethods>

Use `each_key` instead of `keys.each`.
Raw output
modules/meeting/app/forms/recurring_meeting/frequency.rb:39:36: C: Style/HashEachMethods: Use `each_key` instead of `keys.each`.

Check notice on line 35 in modules/meeting/app/forms/recurring_meeting/interval.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/forms/recurring_meeting/interval.rb#L35 <Style/TrailingCommaInArguments>

Avoid comma after the last parameter of a method call.
Raw output
modules/meeting/app/forms/recurring_meeting/interval.rb:35:65: C: Style/TrailingCommaInArguments: Avoid comma after the last parameter of a method call.

Check warning on line 45 in modules/meeting/app/forms/recurring_meeting/specific_date.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/app/forms/recurring_meeting/specific_date.rb#L43-L45 <Lint/MissingSuper>

Call `super` to initialize state of the parent class.
Raw output
modules/meeting/app/forms/recurring_meeting/specific_date.rb:43:3: W: Lint/MissingSuper: Call `super` to initialize state of the parent class.

Check notice on line 1 in modules/meeting/spec/models/recurring_meeting_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/spec/models/recurring_meeting_spec.rb#L1 <Style/StringLiterals>

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw output
modules/meeting/spec/models/recurring_meeting_spec.rb:1:9: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Check notice on line 3 in modules/meeting/spec/models/recurring_meeting_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/spec/models/recurring_meeting_spec.rb#L3 <RSpecRails/InferredSpecType>

Remove redundant spec type.
Raw output
modules/meeting/spec/models/recurring_meeting_spec.rb:3:34: C: RSpecRails/InferredSpecType: Remove redundant spec type.

Check notice on line 1 in modules/meeting/spec/requests/recurring_meetings_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/spec/requests/recurring_meetings_spec.rb#L1 <Style/StringLiterals>

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Raw output
modules/meeting/spec/requests/recurring_meetings_spec.rb:1:9: C: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Check notice on line 3 in modules/meeting/spec/requests/recurring_meetings_spec.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] modules/meeting/spec/requests/recurring_meetings_spec.rb#L3 <RSpecRails/InferredSpecType>

Remove redundant spec type.
Raw output
modules/meeting/spec/requests/recurring_meetings_spec.rb:3:37: C: RSpecRails/InferredSpecType: Remove redundant spec type.