Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update title match regex #16

Merged
merged 1 commit into from
Jan 13, 2025
Merged

update title match regex #16

merged 1 commit into from
Jan 13, 2025

Conversation

PrajwolAmatya
Copy link
Collaborator

@PrajwolAmatya PrajwolAmatya commented Jan 10, 2025

Description

Current regex to get the title works when there is heading present.

## Slide Title ::slide:title-content
slide content

We get the title of the slide as Slide Title.

But as introduction of the new slide template for full image background, we provide the content as:

## ::slide:image
slide content

Here, the title of the slide is returned as slide content, which is not true.

This PR fixes this issue, and returns empty string when there is no title present for this slide.

@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review January 10, 2025 06:28
@PrajwolAmatya PrajwolAmatya self-assigned this Jan 10, 2025
@nirajacharya2
Copy link
Collaborator

if we return empty string the toc will have a item without any text. we need to fix that too

image

@PrajwolAmatya
Copy link
Collaborator Author

PrajwolAmatya commented Jan 10, 2025

if we return empty string the toc will have a item without any text. we need to fix that too

Thanks for noticing this issue. 👍
This issue is from the templates side. I have fixed it in PR opf/revealjs-awesoMD-templates#5

@PrajwolAmatya PrajwolAmatya merged commit 7d04163 into main Jan 13, 2025
3 checks passed
@PrajwolAmatya PrajwolAmatya deleted the update-title-regex branch January 13, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants