make spliting of blocks for any markdown content #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrajwolAmatya
force-pushed
the
fix-split-blocks
branch
2 times, most recently
from
11bc391 to
2efdff7
Compare
PrajwolAmatya
force-pushed
the
fix-split-blocks
branch
2 times, most recently
from
3da1bec to
0adfc12
Compare
plugin/awesoMD/plugin.js
Outdated
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| inCodeBlock = !inCodeBlock | |
| return | |
| } |
There was a problem hiding this comment.
Yeah, we can do it but lets make the code more readable. It will be easy to understand the code.
PrajwolAmatya
force-pushed
the
fix-split-blocks
branch
from
0adfc12 to
494bd53
Compare
PrajwolAmatya
requested review from
nirajacharya2 and
individual-it
and removed request for
nirajacharya2 and
individual-it
PrajwolAmatya
force-pushed
the
fix-split-blocks
branch
from
221004b to
1777331
Compare
PrajwolAmatya
force-pushed
the
fix-split-blocks
branch
from
1777331 to
d8aca20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When code block having empty line within the block, was added in the same slide with alerts, then the blocks were not rendered as expected. Likewise, with other markdown contents. So, proper splitting need to be done. So, with this PR the
splitSlideContentIntoBlocksfunction is refined to support different markdown contents.spitSlideContentIntoBlocksfunctionality to split all markdown contentsplitSlideContentIntoBlocks