Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding mrv and amd #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohamedasifs123
Copy link
Contributor

@mohamedasifs123 mohamedasifs123 commented Aug 21, 2024

Adding mrv and amd cards on ansible

@sandersms
Copy link
Contributor

@mohamedasifs123 Please correct the failing required CI checks so the PR can be reviewed.

Signed-off-by: mohamedasifs123 <[email protected]>
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marvell and amd cards are not in the inventory....
not sure I understand how this PR works...

@sandersms
Copy link
Contributor

@mohamedasifs123 You will need to update your project to pick up the latest changes with resolve the docker-lint issue that Boris checked in here and in the CI processing.

@mohamedasifs123
Copy link
Contributor Author

marvell and amd cards are not in the inventory....
not sure I understand how this PR works...

https://github.com/opiproject/lab/blob/main/ansible%2Finventory#L18
I think amd and mrv is present on inventory under DPUs.

@mohamedasifs123
Copy link
Contributor Author

@mohamedasifs123 You will need to update your project to pick up the latest changes with resolve the docker-lint issue that Boris checked in here and in the CI processing.

I have not modified or added the dockerfile.The error show no dockerfiles found

@sandersms
Copy link
Contributor

@mohamedasifs123 You will need to update your project to pick up the latest changes with resolve the docker-lint issue that Boris checked in here and in the CI processing.

I have not modified or added the dockerfile.The error show no dockerfiles found

The new changes are a check on whether to run the docker-lint or not. In the case of this repository we don't run the docker-lint and that is the change in the files that need to be picked up in your changes.

@glimchb
Copy link
Member

glimchb commented Oct 11, 2024

This code is not working. Both cards are down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants