Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged the telegraf deployment code for all hosts #68

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Sakethanne
Copy link
Contributor

fix(telegraf): merged the telegraf deployment code for all hosts

@Sakethanne Sakethanne requested a review from a team as a code owner October 3, 2024 21:21
ansible/monitoring.yml Outdated Show resolved Hide resolved
ansible/monitoring.yml Outdated Show resolved Hide resolved
read_only: true

# TODO: see if there is an opportunity to consolidate and code dup removal
- name: Add additional mount for bf2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you prefix name with Nvidia | ? as steps before ?

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small comment

@glimchb glimchb merged commit 2acb411 into opiproject:main Oct 7, 2024
9 of 11 checks passed
@glimchb glimchb linked an issue Oct 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in #61, where are the parameters to run container
2 participants