Fix channel closing issue during replay procedure #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A channel is used between the infradb and the task manager is order to inform taks manager that a replay procedure has been finished. By closing the channel when the replay procedure is concluded the task manager is informed this way and continues processing tasks.
The closing of the channel in this case is not the right procedure to inform the task manager. The reason is that in an event that the replay procedure is triggered again in the future infradb will try to close again the channel in order to notify the task manager and that can cause panic.
This PR contains the fix for that.