ECMP feature support #500
Open
ECMP feature support #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Saikumar Banoth <[email protected]> Signed-off-by: atulpatel261194 <[email protected]>
Signed-off-by: Saikumar, Banoth <[email protected]>
Signed-off-by: Atul Patel <[email protected]>
Signed-off-by: atulpatel261194 <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
| @@ -325,81 +332,85 @@ func handlevrf(objectData *eventbus.ObjectData) { | |||
| func disableRpFilter(iface string) { | |||
| // Work-around for the observation that sometimes the sysctl -w command did not take effect. | |||
| rpFilterDisabled := false | |||
| for i := 0; i < 3; i++ { | |||
| for i := 0; i < 5; i++ { | |||
There was a problem hiding this comment.
what's 5 here? create a named const?
| // add static rules into the pipeline of representators read from config | ||
| representors := make(map[string][2]string) | ||
| for k, v := range config.GlobalConfig.P4.Representors { | ||
| /*for k, v := range config.GlobalConfig.P4.Representors { |
There was a problem hiding this comment.
commented code can be removed
| log.Printf("intel-e2000: REPRESENTORS %+v\n", representors) | ||
| log.Printf("intel-e2000: REPRESENTORS %+v\n", representors)*/ | ||
| // Add the physical port representors | ||
| // Add the physical port representors |
| L3 = L3.L3DecoderInit(representors) | ||
| Pod = Pod.PodDecoderInit(representors) | ||
| // decoders = []interface{}{L3, Vxlan, Pod} |
| if err != nil { | ||
| log.Printf("Error getting ids for port_mux: %v", err) | ||
| } else { | ||
| representors["port_mux"] = [2]string{portMuxVsi, portMuxMac} |
There was a problem hiding this comment.
why do we use slice of 2 elements? Maybe a dedicated struct with mux andmac memebrs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
his pull request introduces ECMP (Equal-Cost Multi-Path) Routing Feature, which enhances our network routing capabilities by allowing traffic distribution across multiple paths of equal cost.