fix(deps): update github.com/opiproject/opi-api digest to b3c06e7 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're currently processing your upload. This comment will be updated when the results are available. |
Signed-off-by: Artsiom Koltun <[email protected]>
Signed-off-by: Artsiom Koltun <[email protected]>
artek-koltun
commented
Oct 27, 2023
| case strings.Contains(s1, "X509"): | ||
| ret.Type = pb.CertificateType_CERT_X509 | ||
| ret.Type = pb.CertificateType_CERTIFICATE_TYPE_X509_UNSPECIFIED |
There was a problem hiding this comment.
@sandersms is this correct mapping according to this api change?
Should our api look like this instead, so we could use CERTIFICATE_TYPE_X509 here?
CERTIFICATE_TYPE_UNSPECIFIED = 0;
CERTIFICATE_TYPE_X509 = 1;
CERTIFICATE_TYPE_X509_AC = 2;
CERTIFICATE_TYPE_X509_CRL = 3;
CERTIFICATE_TYPE_OCSP_RESPONSE = 4;
CERTIFICATE_TYPE_PUBKEY = 5;
There was a problem hiding this comment.
good catch @artek-koltun
CERT_X509 = 0;
CERT_X509_AC = 1;
CERT_X509_CRL = 2;
CERT_OCSP_RESPONSE = 3;
CERT_PUBKEY = 4;
to
CERTIFICATE_TYPE_UNSPECIFIED = 0;
CERTIFICATE_TYPE_X509 = 1;
CERTIFICATE_TYPE_X509_AC = 2;
CERTIFICATE_TYPE_X509_CRL = 3;
CERTIFICATE_TYPE_OCSP_RESPONSE = 4;
CERTIFICATE_TYPE_PUBKEY = 5;
instead of
CERTIFICATE_TYPE_X509_UNSPECIFIED = 0;
CERTIFICATE_TYPE_X509_AC = 1;
CERTIFICATE_TYPE_X509_CRL = 2;
CERTIFICATE_TYPE_OCSP_RESPONSE = 3;
CERTIFICATE_TYPE_PUBKEY = 4;
There was a problem hiding this comment.
The issue may require a different fix that I am working now based on the test failure in the strongswan
|
is #241 the same ? |
yeah, didn't notice that PR. Closing this one then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #240
The same CI failure was observed on previous builds like https://github.com/opiproject/opi-strongswan-bridge/actions/runs/6291333341/job/17079616515