Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add receiver refinement in getAnnotatedTypeLhs #210

Closed
wants to merge 10 commits into from
Closed

Add receiver refinement in getAnnotatedTypeLhs #210

wants to merge 10 commits into from

Conversation

AndrewShf
Copy link
Member

@AndrewShf AndrewShf commented Apr 11, 2022 •
edited
Loading

See if the modification can pass all tests

@AndrewShf AndrewShf changed the title just a test pr, see if there's any testcase failure Add receiver refinement in getAnnotatedTypeLhs Apr 11, 2022
@AndrewShf
Copy link
Member Author

AndrewShf commented Apr 21, 2022 •
edited
Loading

This is an alternative to lnsun's pull request #142
, where he wanted to expose private member computingAnnotatedTypeMirrorOfLHS, so he could override getAnnotatedTypeLhs and had receiver refinement in PICO type system.

@AndrewShf
Copy link
Member Author

AndrewShf commented Mar 7, 2023 •
edited
Loading

Another way of achieving this: in ExpressionVisitor to have flow-sensitive refinement for receiver?
https://github.com/eisop/checker-framework/blob/c464d12ea98ba1206f3016bee48c74d88881c052/framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java#L273

@AndrewShf AndrewShf mentioned this pull request Mar 10, 2023
Merged
@AndrewShf
Copy link
Member Author

this PR is replaced by eisop#434

@AndrewShf AndrewShf closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AndrewShf