Masterworkable #16
Open
Masterworkable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Jianchu , is it possible for you to provide a bit hint about why and what specific changes in this PR will break Ontology? Thanks! |
|
@CharlesZ-Chen Are there changes in this PR that haven't been merged into CFI? |
|
@wmdietl I'm a bit forget what we've merged into CFI and what we still left in terms of this PR... Let me re-catch the context and to see if we can close this PR safely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates:
Statistic measurement updates: made thread safe, and collect new data.
Constraint graph updates: update with new slot manager, remove "missing constraint logic"
Dataflow updates: fix bugs in LUB, NP, and missing location.
This change will break Ontology, so don't merge it at this moment.