-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Prefect to 3.1.13 #5518
base: develop
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #5518 will not alter performanceComparing Summary
|
5faefe8
to
5cfba70
Compare
Need to investigate slowness on Prefect startup, it actually takes more than 30 seconds to start Prefect when running with xdist (probably because the CI runner is overwhelmed) Maybe related to PrefectHQ/prefect#16299 |
I have the same problem. I would be cautious about the latest versions of Prefect, many of our data pipelines are experiencing significant flakiness and degredation at the moment due to the performance related issues of the event driven architecture (internally) of prefect since 3.x. Have you experienced anything like that outside of tests? |
This reverts commit 90a508b.
Signed-off-by: Fatih Acar <[email protected]>
34a3af4
to
35d0855
Compare
Signed-off-by: Fatih Acar <[email protected]>
Signed-off-by: Fatih Acar <[email protected]>
Run Prefect only when required. Since we do autouse, it would also run during benchmark tests which is not required. Signed-off-by: Fatih Acar <[email protected]>
In some cases, when the CI runner is overwhelmed, 0.1s may not be enough to successfully send a message to rabbitmq. Increase it to 1 second to be consistent with other tests. Signed-off-by: Fatih Acar <[email protected]>
30 second may not be enough when using Prefect 3.1 which seems to add a little overhead to 3.0. Prefect usually took 20s-25s to start and a small load spike on the CI runner can fail the tests. Signed-off-by: Fatih Acar <[email protected]>
00f3de9
to
7fb484e
Compare
We started using Prefect since 3.0, so we can't tell for previous releases. |
This was previously enabled on git agents but got removed during the transition to task workers. Prefect 3.1 also adds instrumentation to workflow runs. Signed-off-by: Fatih Acar <[email protected]>
This PR is trying to upgrade Prefect to 3.1.13 because we need it for the event management epic as part of 1.2
Prefect made a lot of progress around Typing in 3.1.x but there are still a few issues reported by Mypy.
I opened some issues on prefect github project to track them and I've disabled mypy for these issues for now
overload
for @task and @flow that are part of a class PrefectHQ/prefect#16770