Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter events on multiple levels #5677

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Feb 5, 2025

It seems that if we want to have multiple related resources within an event and still filter against each of them and have the filter become more and more restrictive as in filter anything from a specific account in combination with a branch and other such properties they all need to live within the same related_resource dictionary within the event.

I've opened two feature requests in the Prefect repository around this: PrefectHQ/prefect#16978 & PrefectHQ/prefect#16979

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Feb 5, 2025
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #5677 will not alter performance

Comparing pog-event-filtering-IFC-1209 (33b5656) with develop (7b101be)

Summary

✅ 11 untouched benchmarks

@ogenstad ogenstad marked this pull request as ready for review February 5, 2025 16:18
@ogenstad ogenstad requested a review from a team as a code owner February 5, 2025 16:18
@ogenstad ogenstad merged commit d4fd165 into develop Feb 6, 2025
32 checks passed
@ogenstad ogenstad deleted the pog-event-filtering-IFC-1209 branch February 6, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants