Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Integration code for listVar integration #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cooperreid-optimizely
Copy link
Contributor

Cleaned up the integration code to automatically account for Array and String listVars. Removed the reverse for-loop logic.

@cooperreid-optimizely cooperreid-optimizely changed the title Cleaned up Integration code Cleaned up Integration code for listVar integration Nov 6, 2017
var redirectInfo = window.optimizely.get('state').getRedirectInfo();
var list = "list1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cooperreid-optimizely what's the rational from moving away from a hard-coded list variable key? The reason I put this in was because customers didn't want to modify the list variable used every time so the integration would genuinely be "one click". Just wanted to confirm there's a reason before I merge in.

@cooperreid-optimizely
Copy link
Contributor Author

cooperreid-optimizely commented Nov 8, 2017 via email

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants