Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9494] Update references to old sub modules js-sdk-* #213

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[FSSDK-9494] Update references to old sub modules js-sdk-* #213

merged 2 commits into from
Sep 21, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Sep 21, 2023 •
edited
Loading

Summary

  • JS SDK beta5 removes all old sub-modules. This PR updates the React SDK to use that version and beyond

Test plan

  • All existing tests should pass

Issues

  • FSSDK-9494

@mikechu-optimizely mikechu-optimizely added the enhancement New feature or request label Sep 21, 2023
prisma-cloud-devsecops[bot]
prisma-cloud-devsecops bot reviewed Sep 21, 2023
View reviewed changes
Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

package.json Show resolved Hide resolved
@mikechu-optimizely mikechu-optimizely changed the title [FSSDK-9494] Update references to old sub module js-sdk-* [FSSDK-9494] Update references to old sub modules js-sdk-* Sep 21, 2023
raju-opti
raju-opti approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit de7e992 into master Sep 21, 2023
6 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/upgrade-js-sdk branch September 21, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisma-cloud-devsecops prisma-cloud-devsecops[bot] prisma-cloud-devsecops[bot] left review comments

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @raju-opti