Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9726] AAT gap fill #221

Merged
merged 16 commits into from
Nov 6, 2023
Merged

[FSSDK-9726] AAT gap fill #221

merged 16 commits into from
Nov 6, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Add missing AAT/ODP functions exposed in the JS SDK but not available to React
  • Quality of life improvements

Test plan

  • New unit tests added for coverage
  • Existing unit and e2e tests are expected to pass.

Issues

@mikechu-optimizely mikechu-optimizely added the bug Something isn't working label Oct 27, 2023
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review October 27, 2023 21:32
jaeopt
jaeopt requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of clarifications.

src/client.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
raju-opti
raju-opti requested changes Oct 31, 2023
View reviewed changes
src/client.spec.ts Show resolved Hide resolved
mikechu-optimizely
mikechu-optimizely commented Nov 2, 2023
View reviewed changes
Copy link
Contributor Author

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer re-reviewed

jaeopt
jaeopt requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A clarifying question. Other than that, all looks good!

src/client.ts Outdated Show resolved Hide resolved
raju-opti
raju-opti approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely
Copy link
Contributor Author

@jaeopt Can I get your approval when you have a moment?

jaeopt
jaeopt approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit bc69201 into master Nov 6, 2023
4 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/gap-fixes branch November 6, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikechu-optimizely @jaeopt @raju-opti