Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-8653] OptimizelyVariation with default and variation props set #227

Merged
merged 4 commits into from
Dec 6, 2023
Merged

[FSSDK-8653] OptimizelyVariation with default and variation props set #227

merged 4 commits into from
Dec 6, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Dec 6, 2023 •
edited
Loading

Summary

Test plan

  • Added test coverage for this enhancement
  • Existing unit & e2e tests are expected to pass

Issues

  • FSSDK-8653

@mikechu-optimizely mikechu-optimizely added enhancement New feature or request chore labels Dec 6, 2023
raju-opti
raju-opti approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️

@mikechu-optimizely mikechu-optimizely merged commit 38f3a29 into master Dec 6, 2023
5 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/default-and-variation branch December 6, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-opti raju-opti raju-opti approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
chore enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @raju-opti