Put fiducials in position file #621
Conversation
As the global is set to use the "default" variant that we have set to be "kibom" type, the position files inherit the _mechanical filter which remove unuseful pads from the pick and place file. Fiduals are hence not in the position file normally if the _mechanical filter is applied. see the generic filter explanation; https://github.com/INTI-CMNB/KiBot#supported-filters and the supported variant default value of filter (`exclude_filter`) ; https://github.com/INTI-CMNB/KiBot#supported-variants
|
Great approach @elafontaine. |
|
@G-Pereira I'm wondering if I should be adding a new task to the CI jobs to ensure the file desired are present... And in this case, that it contains the FID component as well. The reasoning I'm following is because someone changing the configuration may cause this problem to re-occur. I see the CI as "continuous imrpovement" not "continuous integration" :). Would you be open to that ? |
|
You can merge this one right away, I would do the suggestion in another issue/PR :) |
|
No Update ? |
|
@sphawes @G-Pereira I would like to know if this is relevant or if I should close it. I'm the kind of men to do one thing per project before moving on to the next thing for that project. and this has been done for almost over a year. Please let me know what you want to do. |
|
Hey, can you re-run the GitHub workflow? The previous one has expired. |
|
@G-Pereira done and I've updated my branch through github |
As the global is set to use the "default" variant that we have set to be "kibom" type, the position files inherit the _mechanical filter which remove unuseful pads from the pick and place file. Fiduals are hence not in the position file normally if the _mechanical filter is applied.
see the generic filter explanation;
https://github.com/INTI-CMNB/KiBot#supported-filters
and the supported variant kibom value of filter (
exclude_filter) ;https://github.com/INTI-CMNB/KiBot#supported-variants
Fix issue #566