Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add namespace to default ingress #84

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: add namespace to default ingress #84

merged 1 commit into from
Aug 14, 2024

Conversation

argoyle
Copy link
Member

@argoyle argoyle commented Aug 14, 2024

No description provided.

peter-svensson
peter-svensson approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@peter-svensson peter-svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a different namespace than default just to be more aligned with "best-practises" and avoid using the defaultnamespace.
Let's do it in a separate PR with a BREAKING CHANGE to delete the existing one...

@argoyle argoyle merged commit 6983cae into main Aug 14, 2024
5 of 6 checks passed
@argoyle argoyle deleted the update-default-ingress-namespace branch August 14, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-svensson peter-svensson peter-svensson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argoyle @peter-svensson