fixed IndexOutOfBoundsException when HeaderSettingsObject is first on…

… the list
or-dvir · May 16, 2018 · 44024e1 · 44024e1
1 parent 3da2046
commit 44024e1
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/.idea/caches/build_file_checksums.ser b/.idea/caches/build_file_checksums.ser
diff --git a/build.gradle b/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.0'
+        classpath 'com.android.tools.build:gradle:3.1.2'
 
 
         // NOTE: Do not place your application dependencies here; they belong

diff --git a/easysettings-basic/src/main/java/com/hotmail/or_dvir/easysettings/pojos/EasySettings.java b/easysettings-basic/src/main/java/com/hotmail/or_dvir/easysettings/pojos/EasySettings.java
@@ -186,7 +186,8 @@ public static void inflateSettingsLayout(Context context,
 				int bottomPadding = individualSettingsContainer.getPaddingBottom();
 				int topPadding = individualSettingsContainer.getPaddingTop();
 
-				if(settingsList.get(i-1).hasDivider())
+				if(i == 0 ||
+				   settingsList.get(i-1).hasDivider())
 				{
 					topPadding = settingsPadding;
 				}

diff --git a/sample/src/main/java/or_dvir/hotmail/com/ActivityMain.java b/sample/src/main/java/or_dvir/hotmail/com/ActivityMain.java
@@ -76,6 +76,8 @@ protected void onCreate(Bundle savedInstanceState)
 		//todo note that there might be some more methods available for the below builders.
 		//todo please check docs/original code for all available options
 		mySettingsList = EasySettings.createSettingsArray(
+				new HeaderSettingsObject.Builder("no more index out of bound")
+						.build(),
 				new BasicSettingsObject.Builder(SETTINGS_KEY_BASIC, "fancy title 1")
 						.setSummary("fancy summary")
 						.setIcon(null)