Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netbeans tests failures #303

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

sid-srini
Copy link
Member

@sid-srini sid-srini commented Oct 26, 2024

  1. Adding the patch for netbeans PR #7910 to prevent tests failures due to CRLF line endings.
  2. Added the use of the extension configuration prefix "jdk" in ServerTest, as had been done for java.lsp.server AttachConfigurations and ProjectConfigurationCompletion, via the patch/rename-debugger.diff.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 26, 2024
@sid-srini sid-srini added this to the JVSC 23.0.1 milestone Oct 26, 2024
1. Adding the patch for netbeans PR #7910 to prevent tests failures
due to CRLF line endings.
2. Added the use of the extension configuration prefix "jdk" in
   ServerTest, as had been done for java.lsp.server/ AttachConfigurations.java
   and ProjectConfigurationCompletion.java, via the
   patch/rename-debugger.diff.

Signed-off-by: Siddharth Srinivasan <[email protected]>
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Achal1607 Achal1607 merged commit 2bac633 into oracle:main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants