Support for Autonomous Database #44
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
did you mean to check this in?
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
Signed-off-by: Mark Nelson <[email protected]>
| @@ -0,0 +1,82 @@ | |||
| // Copyright (c) 2023, Oracle and/or its affiliates. | |||
| "name", "compartment", "password", 200, 2f); | ||
| assertNotNull(cadr); | ||
|
|
||
| //AutonomousDbDetails add = autonomousDatabase.getAutonomousDatabase("ocid"); |
| GenerateAutonomousDatabaseWalletResponse response = autonomousDatabase.generateAutonomousDatabaseWallet(databaseId, password); | ||
| InputStream is = response.getInputStream(); | ||
| int ContentLength = response.getContentLength(); | ||
| // read the InputStream to get the wallet |
There was a problem hiding this comment.
Is this the typical way a wallet is provided to an app?
| </scm> | ||
|
|
||
| <properties> | ||
| <maven.compiler.source>17</maven.compiler.source> |
There was a problem hiding this comment.
indentation, also, compiler should be set in the parent pom
| * Direct instance of OCI Java SDK DatabaseClient. | ||
| * @return DatabaseClient | ||
| */ | ||
| DatabaseClient getDatatbaseClient(); |
There was a problem hiding this comment.
DatabaseClient should already be a bean right?
| Integer dataStorageSizeInGBs, | ||
| Float computeCount | ||
| ) { | ||
| CreateAutonomousDatabaseRequest createAutonomousDatabaseRequest = CreateAutonomousDatabaseRequest.builder() |
There was a problem hiding this comment.
There are a lot more parameters for autonomous database, how does the user supply these? https://docs.oracle.com/en-us/iaas/autonomous-database/doc/create-adb.html
There was a problem hiding this comment.
Also, why would I use this method over calling the SDK directly to create an adb?
| * @param databaseId OCID of the Autonomous Database to get details of | ||
| * @return GetAutonomousDatabaseResponse | ||
| */ | ||
| public AutonomousDbDetails getAutonomousDatabase(String databaseId) { |
There was a problem hiding this comment.
We might want to leave this method unimplemented until the issue is fixed, we're returning SDK objects elsewhere but our own pojo in this case - it may cause problems later on
| * @param databaseId OCID of the Autonomous Database to be deleted | ||
| * @return DeleteAutonomousDatabaseResponse | ||
| */ | ||
| public DeleteAutonomousDatabaseResponse deleteAutonomousDatabase(String databaseId) { |
There was a problem hiding this comment.
does this also delete any backups or other residual objects associated with the database?
No description provided.