Skip to content

Commit

Permalink
fixup!chore(github-action): build cnb image - remove host network, us…
Browse files Browse the repository at this point in the history
…e link instead - custom name
  • Loading branch information
o-orand committed Sep 25, 2024
1 parent 67b499e commit 9489801
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/build-using-cnb-buildpack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
env:
CNB_IMAGE_NAME: cnb-app
# SERVICE_VERSION: '6.0'
SERVICE_HOST: redis
SERVICE_HOST: redis-service
SERVICE_PORT: 6379
# SERVICE_USERNAME: '22032e25-4aba-417f-a394-8bbd78d920cd'
SERVICE_PASSWORD: 'StbQ4EovUpwQjD0cT1Hr7PKBG'
Expand All @@ -24,6 +24,7 @@ jobs:
redis-service:
# Docker Hub image
image: redis
container_name: redis-service
# Set health checks to wait until redis has started
options: >-
--health-cmd "redis-cli ping"
Expand Down Expand Up @@ -82,7 +83,7 @@ jobs:
cat vcap-service.env
docker ps -a
echo "Starting sample app"
container_id=$(docker run -d --link redis -e PORT=8080 --env-file vcap-service.env --name "cnb-app-container" ${{env.CNB_IMAGE_NAME}})
container_id=$(docker run -d --link redis-service -e PORT=8080 --env-file vcap-service.env --name "cnb-app-container" ${{env.CNB_IMAGE_NAME}})
echo "Cnb app started (id: $container_id)"
docker inspect -f '{{.HostConfig.LogConfig.Type}}' $container_id
# docker run -e PORT=80 --env-file vcap-service.env -p 8080:80 --name "cnb-app-container" ${{env.CNB_IMAGE_NAME}}
Expand Down

0 comments on commit 9489801

Please sign in to comment.