feat: dangling node detection for graph.Memory #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiaoxuan Wang <[email protected]>
Signed-off-by: Xiaoxuan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
==========================================
+ Coverage 75.23% 75.32% +0.08%
==========================================
Files 59 59
Lines 5480 5487 +7
==========================================
+ Hits 4123 4133 +10
+ Misses 1001 999 -2
+ Partials 356 355 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 29, 2023
Signed-off-by: Xiaoxuan Wang <[email protected]>
eiffel-fl
reviewed
Nov 29, 2023
| key := descriptor.FromOCI(desc) | ||
| _, existsInMemory := m.nodes[key] | ||
| _, existsInPredecessors := m.predecessors[key] | ||
| return existsInMemory && !existsInPredecessors |
There was a problem hiding this comment.
At a first glance, I missed the !.
I would add a comment stating: "a node is dangling if present in memory without any predecessor", e.g.:
A (root) -> B -> C
D -> E
D is dangling here.
There was a problem hiding this comment.
Good catch. Added the doc comment. A public function should always has doc comments.
Signed-off-by: Xiaoxuan Wang <[email protected]>
|
close this PR as its content is contained in #653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #472
This PR:
graph.Memorygraph.Memory.Remove()return dangling successorsThis draft PR is followed by #653, which implements recursive GC on
oci.Store.