fix: join next link instead of append for pagination in get_tags (#174)

* fix: join next link instead of append for pagination in get_tags * chore: update changelog and version Signed-off-by: Nate Faerber <[email protected]>
oras-project · Dec 6, 2024 · 2fb51e3 · 2fb51e3
1 parent 0596553
commit 2fb51e3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ The versions coincide with releases on pip. Only major versions will be released
 
 ## [0.0.x](https://github.com/oras-project/oras-py/tree/main) (0.0.x)
  - check for blob existence before uploading (0.2.26)
+    - fix get_tags for ECR when limit is None, closes issue [173](https://github.com/oras-project/oras-py/issues/173)
  - retry on 500 (0.2.25)
  - align provider config_path type annotations (0.2.24)
  - add missing prefix property to auth backend (0.2.23)

diff --git a/oras/provider.py b/oras/provider.py
@@ -398,7 +398,7 @@ def _do_paginated_request(
                 break
 
             # use link + base url to continue with next page
-            url = f"{base_url}{link}"
+            url = urllib.parse.urljoin(base_url, link)
 
     @decorator.ensure_container
     def get_blob(

diff --git a/oras/version.py b/oras/version.py
@@ -2,7 +2,7 @@
 __copyright__ = "Copyright The ORAS Authors."
 __license__ = "Apache-2.0"
 
-__version__ = "0.2.25"
+__version__ = "0.2.26"
 AUTHOR = "Vanessa Sochat"
 EMAIL = "[email protected]"
 NAME = "oras"