-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add concept for OCI Artifact #238
Conversation
c3e961b
to
90d48d9
Compare
Signed-off-by: Sajay Antony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks great with feedback.
Biggest concern is the example for multiple SBOMs in an index.
Minor nit/question. What is the formatting guidance? This PR uses the 80 character rule, as opposed to sentences on separate lines for easier commenting.
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Sajay Antony <[email protected]>
Good question. I generally preffer the 80 character limit since its easier to read without rendering, but can change it whatever the guidance /cc @FeynmanZhou is this called out somewhere? |
Signed-off-by: Sajay Antony <[email protected]>
Signed-off-by: Sajay Antony <[email protected]>
I don't know if we have an official standard, but I prefer https://sembr.org/ |
Signed-off-by: Sajay Antony <[email protected]>
@FeynmanZhou @toddysm @shizhMSFT PTAL. |
The benefit of using separate lines for each sentence is you can scope a comment, make a PR to a specific line. |
Signed-off-by: Sajay Antony <[email protected]>
Signed-off-by: Sajay Antony <[email protected]>
Signed-off-by: Sajay Antony <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Sajay Antony <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Sajay Antony <[email protected]>
Co-authored-by: Shiwei Zhang <[email protected]> Signed-off-by: Sajay Antony <[email protected]>
Signed-off-by: Sajay Antony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Preview link - https://deploy-preview-238--oras-project.netlify.app/docs/concepts/artifact