resolved comments

Signed-off-by: Xiaoxuan Wang <[email protected]>
oras-project · Sep 5, 2024 · 2a6ec49 · 2a6ec49
1 parent 42c0434
commit 2a6ec49
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cmd/oras/root/manifest/index/create.go b/cmd/oras/root/manifest/index/create.go
@@ -27,6 +27,7 @@ import (
 	"github.com/spf13/cobra"
 	"oras.land/oras-go/v2"
 	"oras.land/oras-go/v2/content"
+	"oras.land/oras-go/v2/errdef"
 	"oras.land/oras/cmd/oras/internal/argument"
 	"oras.land/oras/cmd/oras/internal/command"
 	"oras.land/oras/cmd/oras/internal/display"
@@ -142,7 +143,7 @@ func getPlatform(ctx context.Context, target oras.ReadOnlyTarget, manifestBytes
 	}
 	// if config size is larger than 4 MiB, discontinue the fetch
 	if manifest.Config.Size >= maxConfigSize {
-		return nil, fmt.Errorf("config is too large")
+		return nil, fmt.Errorf("config size %v exceeds MaxBytes %v: %w", manifest.Config.Size, maxConfigSize, errdef.ErrSizeExceedsLimit)
 	}
 	// fetch config content
 	contentBytes, err := content.FetchAll(ctx, target, manifest.Config)

diff --git a/internal/descriptor/descriptor.go b/internal/descriptor/descriptor.go
@@ -22,7 +22,7 @@ import (
 )
 
 // IsManifest checks if a descriptor describes a manifest.
-// Copied from `oras-go`: https://github.com/oras-project/oras-go/blob/d6c837e439f4c567f8003eab6e423c22900452a8/internal/descriptor/descriptor.go#L67
+// Adapted from `oras-go`: https://github.com/oras-project/oras-go/blob/d6c837e439f4c567f8003eab6e423c22900452a8/internal/descriptor/descriptor.go#L67
 func IsManifest(desc ocispec.Descriptor) bool {
 	switch desc.MediaType {
 	case docker.MediaTypeManifest,