Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(progress): generic progress tracking #1524

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Nov 1, 2024

This PR is an implementation of oras-project/oras-go#839.

The goal is to refactor the core code of progress reporting from the oras CLI code base in order to put it into oras-go for others to implement their own progress reporting method.

The refactored code is in the internal/progress package.

@shizhMSFT shizhMSFT added the experimental Issues or pull requests depending on WIP specs label Nov 1, 2024
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale Inactive issues or pull requests label Dec 17, 2024
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
@shizhMSFT shizhMSFT removed the stale Inactive issues or pull requests label Dec 30, 2024
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 82.09607% with 41 lines in your changes missing coverage. Please review.

Project coverage is 84.16%. Comparing base (836c497) to head (f8503f9).

Files with missing lines Patch % Lines
cmd/oras/internal/display/status/track/target.go 48.27% 10 Missing and 5 partials ⚠️
cmd/oras/root/blob/fetch.go 0.00% 4 Missing and 2 partials ⚠️
...md/oras/internal/display/status/progress/status.go 87.50% 5 Missing ⚠️
...oras/internal/display/status/progress/messenger.go 82.60% 3 Missing and 1 partial ⚠️
cmd/oras/root/blob/push.go 20.00% 2 Missing and 2 partials ⚠️
internal/progress/tracker.go 94.28% 3 Missing and 1 partial ⚠️
cmd/oras/internal/display/status/tty.go 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
- Coverage   84.34%   84.16%   -0.19%     
==========================================
  Files         120      121       +1     
  Lines        5449     5557     +108     
==========================================
+ Hits         4596     4677      +81     
- Misses        606      627      +21     
- Partials      247      253       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT marked this pull request as ready for review December 31, 2024 09:51
@shizhMSFT
Copy link
Contributor Author

shizhMSFT commented Dec 31, 2024

Now we have a failure mark on error:
image

@shizhMSFT shizhMSFT changed the title refactor(oras-go): generic progress tracking refactor(progress): generic progress tracking Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Issues or pull requests depending on WIP specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant